Fixes #8146 "Keyboard navigation : Enter Key should open a recent repository"

[lhiginbotham]

Fixes #8146 "Keyboard navigation : Enter Key should open a recent repository"

Proposed changes

• intercept "Enter" key event and attempt to open the selected repository, if anything is selected

Test methodology

• I've attempted to use the enter key in a variety of scenarios, including when there is no repository selected, when there is a repository selected, when there is no repository selected but the list group is collapsed, and when there is a repository selected but the list group is collapsed
• • Out of these scenarios, there seems to be an issue only when pressing enter when a repository is selected but the list group is collapsed. Since the list group was collapsed, I would have expected a no-op, since we cannot visually tell what repository is selected. I cannot fix this, however, as it seems like the ListViewGroup.CollapsedState property is not accessible (maybe we need to use a newer version of .NET in order to see the API implemented and exposed in this WinForms PR? @RussKie )

Test environment(s)

• Windows 10

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8537 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8537      +/-   ##
==========================================
- Coverage   55.10%   55.04%   -0.06%     
==========================================
  Files         901      901              
  Lines       65050    65055       +5     
  Branches    11726    11727       +1     
==========================================
- Hits        35844    35812      -32     
- Misses      26474    26480       +6     
- Partials     2732     2763      +31     

Flag	Coverage Δ
#production	41.98% <0.00%> (-0.07%)	⬇️
#tests	94.80% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[RussKie]

• it seems like the ListViewGroup.CollapsedState property is not accessible

Yes, the ListView control was enhanced in .NET 5.0, so we'll have access to new features when we upgrade.

• Out of these scenarios, there seems to be an issue only when pressing enter when a repository is selected but the list group is collapsed.

I suppose we can live with that until we upgrade to .NET 5.0.
The only thing I'd suggest is adding a comment in the code noting this behaviour.

[RussKie]

🚀

[lhiginbotham]

@RussKie I've added the comment

[RussKie]

Thank you