Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show "Add submodule" Dialog on taskbar. #8543

Merged
merged 1 commit into from Oct 16, 2020
Merged

Add ability to show "Add submodule" Dialog on taskbar. #8543

merged 1 commit into from Oct 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2020

Fixes #6557

Proposed changes

  • Change FormBorderStyle from SizableToolWindow to SizableWindow

Screenshots

Before

image

After

image

Test methodology

  • Manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 2487b70
  • Git 2.28.0.windows.1
  • Microsoft Windows NT 10.0.19041.0
  • .NET Framework 4.8.4250.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost self-assigned this Oct 14, 2020
@ghost
Copy link
Author

ghost commented Oct 14, 2020

Maybe we need to do this for all modals.

protected GitModuleForm([NotNull] GitUICommands commands)
    : this(commands, enablePositionRestore: true)
{
    ShowInTaskbar = true;
}

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #8543 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8543      +/-   ##
==========================================
- Coverage   55.11%   55.07%   -0.04%     
==========================================
  Files         901      901              
  Lines       64984    64984              
  Branches    11698    11698              
==========================================
- Hits        35818    35793      -25     
- Misses      26414    26427      +13     
- Partials     2752     2764      +12     
Flag Coverage Δ
#production 42.00% <ø> (-0.06%) ⬇️
#tests 94.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mstv
Copy link
Member

mstv commented Oct 15, 2020

As I mentioned in an issue comment: I do not want to see modal dialogs in the Task Switcher list in addition to the (GE) main window.
As far as I know, this is has been "solved" in Win10. Win7 is out of maintenance.

@ghost
Copy link
Author

ghost commented Oct 15, 2020

Tool Window can't appear

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (haven't run)

@RussKie RussKie merged commit a573768 into gitextensions:master Oct 16, 2020
@ghost ghost added this to the 4.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Submodule: Dialog not listed in Windows Task Switcher
3 participants