Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the number of draw calls on the commit info panel. #8568

Merged
merged 1 commit into from Oct 22, 2020
Merged

Reduced the number of draw calls on the commit info panel. #8568

merged 1 commit into from Oct 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2020

Proposed changes

  • Reduce the number of calls to the UpdateRevisionInfo method.

Screenshots

Before

2

After

3

Test methodology

  • Manual
  • Visual

Test environment(s)

  • Git Extensions 33.33.33
  • Build a1c3adc (Dirty)
  • Git 2.28.0.windows.1
  • Microsoft Windows NT 10.0.19041.0
  • .NET Framework 4.8.4250.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost self-assigned this Oct 22, 2020
@ghost ghost requested review from RussKie and mstv October 22, 2020 01:33
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #8568 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8568      +/-   ##
==========================================
+ Coverage   55.05%   55.06%   +0.01%     
==========================================
  Files         901      901              
  Lines       65043    65158     +115     
  Branches    11726    11749      +23     
==========================================
+ Hits        35811    35882      +71     
- Misses      26475    26498      +23     
- Partials     2757     2778      +21     
Flag Coverage Δ
#production 42.03% <100.00%> (+0.04%) ⬆️
#tests 94.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@RussKie RussKie merged commit def901f into gitextensions:master Oct 22, 2020
@ghost ghost added this to the 4.0 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants