Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffmerge updates #8615

Merged
merged 5 commits into from Nov 15, 2020
Merged

Conversation

gerhardol
Copy link
Member

Proposed changes

Various minor changes to difftools (several of them will conflict if separate)
Can be squashed

  • Update TortoiseSVN merge scripts for old MS Office and LibreOffice
    Retained the GE patches, made it easier to merge new changes
    One option is to drop these scripts completely

  • Remove unused TortoiseSVN diff scripts

  • Disable tortoisemerge as a difftool

Limitation in Git (not needed, historical?)
As a workaround, 4d3285a added TortoiseDiff
as an alias, but 'tortoisemerge' should be disabled as a difftool too.
(Can still be added from the Git commandline if this is changed in Git.)

  • Add TortoiseGitIDiff as difftool

Only for image files, so mostly usable for custom difftool introduced
in da2c85e

  • DiffMerge: Incorrect suggested exe name
    Related issue It is not possible to resolve conflict #8611

  • Add Sublime Merge (smerge) as a difftool
    I looked into adding other diff/mergetools supported natively in Git,
    smerge was the only I found useful
    (I looked at the free versions of ExamDiff, Code Compare, Diffuse Merge)

  • Add TortoiseGitIDiff as difftool

Only for image files, so mostly usable for custom difftool introduced
in da2c85e

Test methodology

Updated tests, manual


✒️ I contribute this code under The Developer Certificate of Origin.

Align GE patches with latest versions

Remove unused diff scripts
Limitation in Git (not needed, historical?)
As a workaround, 4d3285a added TortoiseDiff
as an alias, but 'tortoisemerge' should be disabled as a difftool too.
(Can still be added from the Git commandline if this is changed in Git.)
Only for image files, so mostly usable for custom difftool introduced
in da2c85e
@ghost ghost assigned gerhardol Nov 14, 2020
@gerhardol gerhardol changed the title Feature/diffmerge updates Smaller diffmerge updates Nov 14, 2020
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #8615 (f10e21a) into master (1928664) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #8615      +/-   ##
==========================================
- Coverage   55.13%   55.12%   -0.01%     
==========================================
  Files         904      906       +2     
  Lines       65506    65524      +18     
  Branches    11864    11864              
==========================================
+ Hits        36115    36122       +7     
- Misses      26561    26572      +11     
  Partials     2830     2830              
Flag Coverage Δ
production 42.13% <26.31%> (+<0.01%) ⬆️
tests 94.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gerhardol gerhardol changed the title Smaller diffmerge updates diffmerge updates Nov 15, 2020
@RussKie RussKie merged commit 6982b15 into gitextensions:master Nov 15, 2020
@ghost ghost added this to the 4.0 milestone Nov 15, 2020
@gerhardol gerhardol deleted the feature/diffmerge-updates branch November 14, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants