Prefer correct local and remote branches sort to tags #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git tags may be concrete refs and ephemeral (i.e. dereferences), which adds a layer of complexity to sorting refs. The original sort mechanism ordered by refs first, followed by derefs. However it caused local and remote branches to be sorted incorrectly. Invert the sort order to ensure branches are sorted correctly at the expense of correct tags order. Relates to gitextensions#8621
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8622 +/- ##
==========================================
+ Coverage 55.12% 55.14% +0.01%
==========================================
Files 906 906
Lines 65546 65546
Branches 11871 11871
==========================================
+ Hits 36135 36148 +13
+ Misses 26585 26573 -12
+ Partials 2826 2825 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
gerhardol
approved these changes
Nov 20, 2020
mstv
approved these changes
Nov 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #8621
Proposed changes
Git tags may be concrete refs and ephemeral (i.e. dereferences), which
adds a layer of complexity to sorting refs.
The original sort mechanism ordered by refs first, followed by derefs.
However it caused local and remote branches to be sorted incorrectly.
Invert the sort order to ensure branches are sorted correctly at the expense
of correct tags order.
✒️ I contribute this code under The Developer Certificate of Origin.