Submodule context menus: Only show if dir exists #8646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8646 +/- ##
==========================================
- Coverage 55.09% 55.09% -0.01%
==========================================
Files 906 906
Lines 65562 65581 +19
Branches 11874 11875 +1
==========================================
+ Hits 36124 36134 +10
- Misses 26602 26612 +10
+ Partials 2836 2835 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
gerhardol
force-pushed
the
feature/submodule-directory-exists
branch
from
8b8f229
to
dadcc6c
Compare
mstv
reviewed
Dec 8, 2020
mstv
approved these changes
Dec 9, 2020
|
@msftbot merge in 48 hours |
|
Hello @gerhardol! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8104
A few other NBug issues exist. I have considered this to be a too much edge case to fix it. Maybe users experience this before they have downloaded submodules? Or this is an indication that there are few serious NBug issues that are not reported.
There has been cleanups for access to submodule dirs in changes the last year, for instance #7690 and #8117, to not access submodules if the directories does not exist.
Proposed changes
Only show context menus for work tree submodules "internals" if the submodule directories exists, required for the Git commands to run.
For FormCommit, the menus are disabled.
For RevDiff the menus the are not shown. The Controller structure (which is made this way to test) adds another layer to handle enable/disable and makes this quite complicated, it is not worth the effort.
Screenshots
Before
After
Test methodology
Added a test
✒️ I contribute this code under The Developer Certificate of Origin.