New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render tabs in the text viewer #8659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8659 +/- ##
=======================================
Coverage 55.15% 55.15%
=======================================
Files 907 907
Lines 65626 65626
Branches 11881 11881
=======================================
+ Hits 36193 36194 +1
+ Misses 26604 26603 -1
Partials 2829 2829
Flags with carried forward coverage won't be shown. Click here to find out more. |
Good catch. But I don't see a difference in the commit-message editor. Tabs have already been rendered. |
How do you mean? If you go to reword a commit and put some tabs in the editor, you will not see them, but they exist (can be deleted accordingly i.e. press tab 7 times, you will have to delete or traverse with arrow keys 7 times to account for it). |
... that the changed submodule is not used yet.
|
I also had some problems to find the issue... |
@msftbot merge in 24 hours |
Hello @gerhardol! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Update TextViewer to include a submodule update by @lhiginbotham that not yet is applied to the main application.
https://github.com/gitextensions/ICSharpCode.TextEditor/pull/23/files
gitextensions/ICSharpCode.TextEditor#22
Proposed changes
See submodule changes
Test methodology
Manual - see submodule
✒️ I contribute this code under The Developer Certificate of Origin.