Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for UTF-7 #8661

Merged
2 commits merged into from Dec 8, 2020
Merged

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Dec 6, 2020

See: dotnet/docs#19274

Fixes #8363
Fixes #8367
Fixes #8425
Fixes #8634

Screenshots

Before

image
image

After

image
image


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned RussKie Dec 6, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #8661 (177745f) into master (0dbdcd6) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #8661      +/-   ##
==========================================
- Coverage   55.15%   55.14%   -0.01%     
==========================================
  Files         907      907              
  Lines       65626    65627       +1     
  Branches    11881    11883       +2     
==========================================
- Hits        36193    36190       -3     
- Misses      26604    26605       +1     
- Partials     2829     2832       +3     
Flag Coverage Δ
production 42.10% <50.00%> (-0.01%) ⬇️
tests 94.92% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussKie
Copy link
Member Author

RussKie commented Dec 7, 2020

@msftbot merge in 27 hours

@ghost ghost added the status: auto merge label Dec 7, 2020
@ghost
Copy link

ghost commented Dec 7, 2020

Hello @RussKie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 08 Dec 2020 04:18:16 GMT, which is in 1 day and 3 hours

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment