Fix high CPU usage of TeamCityAdapter #8716
Conversation
Exceptions thrown from TeamCityAdapter caused immediate retry of failing operations -> spawning lot of new threads without any delay. Fixes gitextensions#8281
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8716 +/- ##
==========================================
- Coverage 55.70% 55.69% -0.01%
==========================================
Files 899 899
Lines 65055 65055
Branches 11733 11733
==========================================
- Hits 36238 36233 -5
+ Misses 25982 25981 -1
- Partials 2835 2841 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Thank you. Will wait for a feedback from users reported the issue before merging. |
|
Have tested the teamcity integration and it still works. It prompted me for credentials correctly (for the first time in ages) and handles network connection/dissconnection gracefully on refresh where it seemed more flakey beforehand. So no regressions and and looks like a promising fix. Thank you! |
|
@msftbot merge in 48 hours |
|
Hello @RussKie! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
|
For Jenkins, this PR causes a regression: New builds are not detected. |
Do we need to roll this back for 3.5? |
|
You can manually refresh so there is a workaround. I will try to investigate and create an issue |
|
Ups, sorry for regression :'( And yes, it's really hard to debug. I spent another few hours now trying to debug/fix high CPU bug another way without success. It (#8281) was introduced by one or both of these PRs - #7452, #7485. I'm not experienced with neither Rx nor Microsoft.VisualStudio.Threading so if anyone can spot what's wrong in BuildServerWatcher.cs or point me in the right direction I'll be happy to try it and test it against TC build server. |
|
AppVeyor likely have the same problem as Jenkins (GetFinishedBuildsSince() is always empty, all builds retrieved in GetRunningBuilds()). I do not get any AppVeyor builds with 3.4.3 or 3.3 either, (I have had that for some time, I thought it was after som experiments) and cannot get it working. |
|
I have no problems with AppVeyor: |
See #8828 |
Fixes #8281 and possibly also fixes #3646 and fixes #8167
Exceptions thrown from TeamCityAdapter caused immediate retry of failing operations -> spawning lot of new threads without any delay.
Before
These cases caused high CPU usage:
After
CPU usage stays minimal. Build server is queried in defined time intervals even when responding errors or not communicating.
Test methodology
Manually testing TeamCity integration and:
Other build server types could be affected and were not tested.
✒️ I contribute this code under The Developer Certificate of Origin.