Fix filter by branch with globbing characters *?[] #8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8801 +/- ##
==========================================
+ Coverage 55.99% 56.04% +0.04%
==========================================
Files 905 920 +15
Lines 65301 65614 +313
Branches 11882 11999 +117
==========================================
+ Hits 36568 36771 +203
- Misses 25794 25842 +48
- Partials 2939 3001 +62
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
reviewed
Jan 26, 2021
gerhardol
reviewed
Jan 26, 2021
gerhardol
reviewed
Feb 3, 2021
| $"--pretty=format:\"{FullFormat}\"", | ||
| { |
There was a problem hiding this comment.
Any reason to switch order?
I would pprefer to move this option close to the other where branchFilter is handled (either here or to line 194)
There was a problem hiding this comment.
Any reason to switch order?
No reason, my mistake. Moved back to where it was.
ghost
added this to the
RussKie
pushed a commit
that referenced
this pull request
Feb 4, 2021
Fix filter by branch with globbing characters *?[] (cherry picked from commit b2a1696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8800
Test methodology
Manually
Test environment(s)
Windows 10
✒️ I contribute this code under The Developer Certificate of Origin.