Fix toolbar order (revisited) #8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
force-pushed
the
fix_toolbar_order2
branch
2 times, most recently
from
f841949
to
9278fc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #8807 +/- ##
==========================================
+ Coverage 55.66% 56.01% +0.35%
==========================================
Files 894 905 +11
Lines 64855 65315 +460
Branches 11870 11885 +15
==========================================
+ Hits 36103 36589 +486
+ Misses 25809 25795 -14
+ Partials 2943 2931 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
mstv
approved these changes
Jan 30, 2021
The designer keeps on wrecking havoc with toolbars. Revisit the toolbar layout workaround, and add assertions to validate the outcome.
RussKie
force-pushed
the
fix_toolbar_order2
branch
from
4c92ecc
to
6b7c2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The designer keeps on wrecking havoc with toolbars - i.e. the order appears to be semi random and not expected.
Revisit the toolbar layout workaround, and add assertions to validate the outcome.
Related #8719
✒️ I contribute this code under The Developer Certificate of Origin.