Correct padding increase

[RussKie]

#8557 introduced new margins and borders, however those margins and borders are not correctly calculated in scaled environments, i.e. scale factor >100%.

@ivangrek in #8732 has provided probably a more "correct" fix, however this is a smaller and more targeted fix.

Resolves #8698
Closes #8732

Screenshots

Before

After

Test methodology

• manual

---

✒️ I contribute this code under The Developer Certificate of Origin.

[ghost]

Why does it work? 😄

[codecov]

Codecov Report

Merging #8819 (ed9e005) into master (e3d1bee) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8819      +/-   ##
==========================================
+ Coverage   56.10%   56.13%   +0.03%     
==========================================
  Files         919      919              
  Lines       65524    65529       +5     
  Branches    11997    11997              
==========================================
+ Hits        36759    36784      +25     
+ Misses      25770    25754      -16     
+ Partials     2995     2991       -4     

Flag	Coverage Δ
production	43.29% <100.00%> (+0.04%)	⬆️
tests	94.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[RussKie]

Why does it work? 😄

As described in #8698 (comment) something in the layout engine triggers multiple padding scaling:

There's definitely something in our code that scales paddings 4(!) times: 1 -> 2 -> 3 -> 4 -> 6.

this.MainSplitContainer.Panel1.ResumeLayout(false); // 1 -> 2px
...
this.MainSplitContainer.ResumeLayout(false); // 2 -> 3px
...
this.toolPanel.ResumeLayout(false); // 3 -> 4px
...
this.ResumeLayout(false); // 4 -> 6px

In this change I force the padding to 1 after all the layout is done, thus making it expected.

[gerhardol]

+1
I would prefer #8732 but can live with this fix

[RussKie]

I'd like to reduce amount of changes until after we migrate to .NET 5. I expect some thing may actually change, and some things may require an update.

[RussKie]

We can revisit the implementation after the migration.

[mdonatas]

this seems like the popular case of "fix one, break another" :)
there's now fat padding around main controls

[ghost]

there's now fat padding around main controls

This is conceived, but I agree, we can reduce by 2 pixels to 8 pixels like in VS.

[mdonatas]

to 8px? why not 0px? I'm running an older build where IMO it looks the best.
Even in VS you don't get a thick padding on all sides and what's more important in VS say Solution Explorer is docked (you can drag it out) so you kinda need to show that visually. I've just checked Slack, Notepad++, Windows Terminal, Windows Explorer and in there controls go to the sides of the window - no wasted space.

Also in VS when you don't dock, there is no wasteful padding

[ghost]

[ghost]

to 8px? why not 0px? I'm running an older build where IMO it looks the best.

In this case, it is necessary to delete everywhere. And use one line as separator and use color for selection.

[mstv]

(This issue deals with the DPI scaling.)

We have started a very similar discussion in #8711.

There is no additional border left to the vertical tabs in MSVS. The bars to the left belong to the tabs (maybe in analogy to the Windows task bar).

Perhaps MSVS is somewhat too special to be taken as the example UI.