Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect colors for left panel icons #8821

Merged
merged 1 commit into from Feb 4, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Feb 4, 2021

Screenshots

Before

image

After

image


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned RussKie Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #8821 (18cd6ac) into master (e3d1bee) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8821      +/-   ##
==========================================
+ Coverage   56.10%   56.11%   +0.01%     
==========================================
  Files         919      919              
  Lines       65524    65518       -6     
  Branches    11997    11997              
==========================================
+ Hits        36759    36768       +9     
+ Misses      25770    25753      -17     
- Partials     2995     2997       +2     
Flag Coverage Δ
production 43.27% <ø> (+0.02%) ⬆️
tests 94.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the modified icons, but this should of course be consistent

@RussKie
Copy link
Member Author

RussKie commented Feb 4, 2021

I like the modified icons

You do? I'm a little surprised tbh, I guess you have better night vision :)

@RussKie RussKie merged commit d029026 into gitextensions:master Feb 4, 2021
@RussKie RussKie deleted the fix_icons branch February 4, 2021 23:53
@ghost ghost added this to the 3.6 milestone Feb 4, 2021
@RussKie RussKie modified the milestones: 3.6, 3.5 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants