Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins: requery new running jobs #8833

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

gerhardol
Copy link
Member

Fixes #8829

Proposed changes

Jenkins was not requeried since a1fb666
This does not seem to be a problem for other buildservers,
AppVeyor requires a manual refresh anyway.

This is not an issue if the build starts immediately after a push, but there could be a queue to start the build, then refresh is needed.

Test methodology

  • Create a new commit, refresh grid but do not push it
  • push the commit from command line
  • check that the build status is updated

✒️ I contribute this code under The Developer Certificate of Origin.

Jenkins was not requeried since a1fb666
This does not seem to be a problem for other buildservers,
AppVeyor requires a manual refresh anyway.
@ghost ghost assigned gerhardol Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #8833 (ebeecba) into master (b69f89e) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8833      +/-   ##
==========================================
+ Coverage   56.10%   56.15%   +0.05%     
==========================================
  Files         919      919              
  Lines       65522    65522              
  Branches    11997    11997              
==========================================
+ Hits        36760    36794      +34     
+ Misses      25759    25740      -19     
+ Partials     3003     2988      -15     
Flag Coverage Δ
production 43.32% <0.00%> (+0.07%) ⬆️
tests 94.47% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works - :shipit:

@gerhardol
Copy link
Member Author

@msftbot merge in 1 day

@ghost ghost added the status: auto merge label Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Hello @gerhardol!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 11 Feb 2021 11:33:59 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@RussKie RussKie merged commit 18616ed into gitextensions:master Feb 10, 2021
@ghost ghost added this to the 3.6 milestone Feb 10, 2021
@RussKie RussKie modified the milestones: 3.6, 3.5 Feb 10, 2021
@gerhardol gerhardol deleted the feature/jenkins-requery branch February 10, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins build: No queries when builds have finished
2 participants