Check if path exists before creating FileInfo #8840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will avoid exceptions for illegal characters etc
Codecov Report
@@ Coverage Diff @@
## master #8840 +/- ##
==========================================
+ Coverage 56.10% 56.11% +0.01%
==========================================
Files 919 919
Lines 65522 65521 -1
Branches 11997 11996 -1
==========================================
+ Hits 36760 36770 +10
+ Misses 25759 25752 -7
+ Partials 3003 2999 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
reviewed
Feb 10, 2021
Comment on lines
-2470
to
-2474
| if (string.IsNullOrWhiteSpace(filePath)) | ||
| { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
All other changes make sense, but this change is surprising in the given context. Could you please elaborate on this?
There was a problem hiding this comment.
null annotation is coming soon...
null is an acceptable input with the change so the caller do not need to check
RussKie
added
the
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will avoid exceptions for illegal characters etc
Fixes #8839
Proposed changes
Use File.Exists(path) before FileInfo(path) to avoid exceptions.
Can be seen as a follow up to #8575
Test methodology
review
✒️ I contribute this code under The Developer Certificate of Origin.