3.5 AppVeyor: Handle v2 tokens #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 tokens require that the account is prepended to the request.. This apparently is only required for quering repos for an account, not normal info. * Only query for project names for a configured account if no account/repo at all is specified Illegal repos will not report any builds anyway. This allows a AppVeyor username/token at the same time as multiple repos are used. For instance can gitextensions/gitextensions builds be seen at the same time as user private builds * Allow configuring of account/repo also if accountName is set * Less aggressive requery of running AppVeyor jobs * Refactor * remove static variables/functions * Handle projectId/name as account/repo consistently * Use local functions (and inline code) * Remove internal data class Project (the module global is no longer needed)
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## release/3.5 #8856 +/- ##
================================================
- Coverage 56.12% 43.20% -12.92%
================================================
Files 919 900 -19
Lines 65522 63026 -2496
Branches 11997 11455 -542
================================================
- Hits 36771 27229 -9542
- Misses 25748 34067 +8319
+ Partials 3003 1730 -1273
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8830 for 3.5
This is not a blocker, but something that should be included.
v2 tokens require that the account is prepended to the request..
This apparently is only required for quering repos for an account,
not normal info.
Only query for project names for a configured account if no
account/repo at all is specified
Illegal repos will not report any builds anyway.
This allows a AppVeyor username/token at the same time as multiple
repos are used. For instance can gitextensions/gitextensions builds
be seen at the same time as user private builds
Allow configuring of account/repo also if accountName is set
Less aggressive requery of running AppVeyor jobs
Refactor
✒️ I contribute this code under The Developer Certificate of Origin.