Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link style was not applied to the dashboard #8860

Merged

Conversation

gerhardol
Copy link
Member

Fixes #

Proposed changes

Apply theme to dashboard links.
theme is null when applying the link theme. No exception, but no effect.
This could be considered for 3.5 too.

An alternative to applying the theme is to remove the theme handling here.

Screenshots

Before

image

image

After

image

image

Test methodology

Manual


✒️ I contribute this code under The Developer Certificate of Origin.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #8860 (870aa3b) into master (26361af) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8860      +/-   ##
==========================================
+ Coverage   56.20%   56.22%   +0.01%     
==========================================
  Files         921      921              
  Lines       65579    65579              
  Branches    11991    11991              
==========================================
+ Hits        36861    36874      +13     
+ Misses      25726    25713      -13     
  Partials     2992     2992              
Flag Coverage Δ
production 43.40% <0.00%> (+0.02%) ⬆️
tests 94.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@drewnoakes
Copy link
Member

You could convert it from a field to a local. It's only used within RefreshContent. Then it can be declared as non-null.

drewnoakes added a commit to drewnoakes/gitextensions that referenced this pull request Feb 15, 2021
@RussKie
Copy link
Member

RussKie commented Feb 17, 2021

Merge at will.

@gerhardol gerhardol merged commit 424ccf2 into gitextensions:master Feb 17, 2021
@ghost ghost added this to the 3.6 milestone Feb 17, 2021
@gerhardol gerhardol deleted the feature/dashboard-link-theme branch February 17, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants