Fix ownership of FormUpdates #8861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FormBrowse` is the main form, and hence it doesn't have `Owner` set. This leads to `FormUpdates` being created as an orphant modal form, that can be hidden behind `FormBrowse` and making the app look unresponsive. Correct the ownership and, thus, force the new form to show above the main form.
ghost
assigned 
drewnoakes
approved these changes
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #8861 +/- ##
==========================================
- Coverage 56.11% 53.13% -2.98%
==========================================
Files 919 844 -75
Lines 65523 60927 -4596
Branches 11997 11672 -325
==========================================
- Hits 36768 32375 -4393
+ Misses 25758 25695 -63
+ Partials 2997 2857 -140
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Maybe just use null? 'FormBrowse' is always owner. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormBrowseis the main form, and hence it doesn't haveOwnerset. This leads toFormUpdatesbeing created as an orphan modal form, that can be hidden behindFormBrowseand making the app look unresponsive.Correct the ownership and, thus, force the new form to show above the main form.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.