Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Git commands related to submodules-3.5 #8870

Conversation

gerhardol
Copy link
Member

#8866 for 3.5

@ghost ghost assigned gerhardol Feb 22, 2021
@gerhardol gerhardol changed the title Cache Git commands related to submodules Cache Git commands related to submodules-3.5 Feb 22, 2021
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit is identical.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #8870 (e6d34b9) into release/3.5 (eea10a7) will decrease coverage by 0.02%.
The diff coverage is 45.00%.

@@               Coverage Diff               @@
##           release/3.5    #8870      +/-   ##
===============================================
- Coverage        56.16%   56.14%   -0.03%     
===============================================
  Files              923      923              
  Lines            65674    65676       +2     
  Branches         12023    12027       +4     
===============================================
- Hits             36888    36873      -15     
- Misses           25781    25795      +14     
- Partials          3005     3008       +3     
Flag Coverage Δ
production 43.33% <40.00%> (-0.04%) ⬇️
tests 94.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gerhardol gerhardol marked this pull request as draft February 22, 2021 23:14
@gerhardol gerhardol marked this pull request as ready for review February 23, 2021 20:18
@gerhardol
Copy link
Member Author

Squashed the same fixup as in #8866

* Cache commands with sha input and no variable input like Git Notes
Only fetch Git Notes for commands that are not cached

* Cache GetCommitRangeDiffCount (for rev-diff)

* Increase Git command cache to 50
@gerhardol gerhardol force-pushed the feature/cache-submodule-commands-3.5 branch from fe99023 to f7c94da Compare February 24, 2021 20:18
@gerhardol
Copy link
Member Author

Only applied the same change as in master yesterday, squashed today so the commits are identical in master and 3.5

@gerhardol gerhardol merged commit efa2a87 into gitextensions:release/3.5 Feb 24, 2021
@gerhardol gerhardol deleted the feature/cache-submodule-commands-3.5 branch February 24, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants