Remove redundant null check #8876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All callers pass a non-null delegate. This code is now annotated, so future code will not pass null either.
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8876 +/- ##
==========================================
+ Coverage 56.01% 56.04% +0.02%
==========================================
Files 922 922
Lines 65945 65944 -1
Branches 12071 12070 -1
==========================================
+ Hits 36942 36956 +14
+ Misses 25989 25984 -5
+ Partials 3014 3004 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
gerhardol
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes a redundant null check.
All callers pass a non-null delegate. This code is now annotated, so future code will not pass null either.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.