Avoid boxing while unpacking flags

[drewnoakes]

Proposed changes

Eliminate boxing when in GitItemStatus bool property getters.

Enum.HasFlag boxes its argument. Replace it with a method that does not.

Test methodology

• Manual testing

---

✒️ I contribute this code under The Developer Certificate of Origin.

[codecov]

Codecov Report

Merging #8882 (e457516) into master (b6905f1) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8882      +/-   ##
==========================================
- Coverage   56.03%   55.78%   -0.25%     
==========================================
  Files         922      916       -6     
  Lines       65944    65447     -497     
  Branches    12070    11988      -82     
==========================================
- Hits        36951    36509     -442     
- Misses      25985    25986       +1     
+ Partials     3008     2952      -56     

Flag	Coverage Δ
production	43.24% <100.00%> (-0.02%)	⬇️
tests	95.04% <ø> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[mstv]

BTW: The name of the enum Flags is misleading. It should be in singular.
I can read this better:

Suggested change

	private bool HasFlag(Flags flags)
	{
	// NOTE Enum.HasFlag boxes its argument
	return (flags & _flags) == flags;
	}
	private bool HasFlag(Flags flag)
	{
	// NOTE Enum.HasFlag boxes its argument
	return (_flags & flag) == flag;
	}

[drewnoakes]

The logic works equally well with multiple flags. The type is a flags enum, and has a plural name.

[mstv]

The logic works equally well with multiple flags.

This was clear to me. But Enum.HasFlag uses only singular. And nothing else is used here.

Better readability (as in other recent PRs):

Suggested change

	private bool HasFlag(Flags flags)
	{
	// NOTE Enum.HasFlag boxes its argument
	return (flags & _flags) == flags;
	}
	private bool HasFlag(Flags flags)
	{
	// NOTE Enum.HasFlag boxes its argument
	return (_flags & flags) == flags;
	}

[gerhardol]

+1
Agree with mstv

[RussKie]

IIRC .NET Core has resolved these allocations, hasn't it? #8522 makes this change obsolete.

[drewnoakes]

@RussKie what change are you looking for here?

[gerhardol]

@RussKie what change are you looking for here?

I believe it was a comment that the change is not necessary as .NET5 should be coming soon
Suggest this is merged now, an improvement regardless