Eliminate closure allocations #8887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes 427,688 bytes of closure allocations while loading GE with the gitextensions repo. Passing the argument on the stack allows the delegate to be cached by the compiler, rather than allocating a new instance for each call.
Codecov Report
@@ Coverage Diff @@
## master #8887 +/- ##
==========================================
+ Coverage 56.03% 56.06% +0.03%
==========================================
Files 922 922
Lines 65944 65824 -120
Branches 12070 12071 +1
==========================================
- Hits 36951 36905 -46
+ Misses 25985 25911 -74
Partials 3008 3008
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Feb 25, 2021
RussKie
added
the
📭 needs: author feedback
Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
ghost
removed
the
📭 needs: author feedback
|
Hello @drewnoakes! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 24 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change removes 427,688 bytes of closure allocations while loading GE with the gitextensions repo.
Passing the argument on the stack allows the delegate to be cached by the compiler, rather than allocating a new instance for each call.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.