Eliminate boxing allocation #8888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes 537,404 bytes of boxed enum allocations while loading GE with the gitextensions repo.
Codecov Report
@@ Coverage Diff @@
## master #8888 +/- ##
==========================================
- Coverage 56.03% 56.03% -0.01%
==========================================
Files 922 922
Lines 65944 65944
Branches 12070 12070
==========================================
- Hits 36951 36950 -1
- Misses 25985 25986 +1
Partials 3008 3008
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
reviewed
Feb 25, 2021
Comment on lines
-889
to
+891
| if (!AppSettings.ShowGitNotes && refFilterOptions.HasFlag(RefFilterOptions.All | RefFilterOptions.Boundary)) | ||
| if (!AppSettings.ShowGitNotes && (refFilterOptions & gitNotesOptions) == gitNotesOptions) |
There was a problem hiding this comment.
IIRC .NET Core has resolved this allocations, hasn't it? #8522 makes this change obsolete.
There was a problem hiding this comment.
Yes, it's not needed under .NET Core. What is the timeline for porting?
Until such a time, I suggest merging this. I ran a trace over GE startup and this was a quick win from the top 30 types allocated on the heap.
There was a problem hiding this comment.
then this should go into 3.5 too
.NET5 is likely in next version
There was a problem hiding this comment.
Sibling PR targeting 3.5: #8889
RussKie
added
the
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Works for me
|
RussKie
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change removes 537,404 bytes of boxed enum allocations while loading GE with the gitextensions repo.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.