Refactor PaintGraphCell #8897
Merged
Refactor PaintGraphCell #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8897 +/- ##
==========================================
+ Coverage 56.06% 56.07% +0.01%
==========================================
Files 922 922
Lines 65843 65842 -1
Branches 12073 12071 -2
==========================================
+ Hits 36912 36924 +12
+ Misses 25918 25914 -4
+ Partials 3013 3004 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Seems to work 👍 |
|
@drewnoakes, could you review, please? |
drewnoakes
approved these changes
Mar 10, 2021
|
|
||
| int top = g.RenderingOrigin.Y; | ||
| Rectangle laneRect = new(0, top, width, rowHeight); | ||
| Region newClip = new(laneRect); | ||
| newClip.Intersect(oldClip); | ||
| g.Clip = newClip; | ||
| g.Clear(Color.Transparent); |
There was a problem hiding this comment.
Why do we need to use Clear vs. FillRegion? The latter would avoid needing to set/restore the Clip.
There was a problem hiding this comment.
Clip is needed anyway in order to create the impression of drawn through graph lines by not letting end the lines at the row borders.
GitUI/UserControls/RevisionGrid/Columns/RevisionGraphColumnProvider.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
SmoothingModetrueifnestingvarScreenshots
N/A
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.