Hide theme fields for serialization from public interface #8907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8907 +/- ##
==========================================
- Coverage 56.06% 56.06% -0.01%
==========================================
Files 925 925
Lines 65899 65901 +2
Branches 12091 12092 +1
==========================================
+ Hits 36946 36947 +1
- Misses 25934 25939 +5
+ Partials 3019 3015 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Mar 1, 2021
RussKie
pushed a commit
that referenced
this pull request
Mar 2, 2021
Hide theme data properties from its public interface, since they don't provide a behavior one would naturally expect from a public property with a given name. The only intended usage for these properties is serialization. (cherry picked from commit acd50e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hide theme data properties from its public interface, since they don't provide a behavior one would naturally expect from a public property with a given name.
The only intended usage for these properties is serialization.
#8904 discovered a problem which this PR would have prevented.
✒️ I contribute this code under The Developer Certificate of Origin.