Remove unused field from RevisionDiffController #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is stateless. Update consuming code too.
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8927 +/- ##
==========================================
+ Coverage 56.05% 56.08% +0.02%
==========================================
Files 925 925
Lines 65913 65906 -7
Branches 12095 12095
==========================================
+ Hits 36948 36962 +14
+ Misses 25949 25933 -16
+ Partials 3016 3011 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove unused field from
RevisionDiffController. This class is stateless. Update consuming code too.Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.