Remove redundant property setters #8929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read only properties have the stronger guarantee that their value will not change over time, making reasoning about the containing type's behaviour easier.
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #8929 +/- ##
==========================================
+ Coverage 56.05% 56.07% +0.01%
==========================================
Files 925 925
Lines 65913 65913
Branches 12095 12095
==========================================
+ Hits 36948 36958 +10
+ Misses 25949 25941 -8
+ Partials 3016 3014 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi, this change breaks the Gerrit Plugin again :/ But I'm not totally sure if we can replace or remove it in the plugin, so maybe I can get a hint for this -> PR 29 |
thimmy687
added a commit
to thimmy687/GitExtensions.GerritPlugin
that referenced
this pull request
Mar 21, 2021
https: //github.com/gitextensions/gitextensions/pull/8929 Change-Id: I56b620441afc4db9ab1010ee49ca0bd36ba18226
thimmy687
added a commit
to thimmy687/GitExtensions.GerritPlugin
that referenced
this pull request
Mar 21, 2021
https: //github.com/gitextensions/gitextensions/pull/8929 Change-Id: I6133f86eb0b6305b87c0a30a386a157e2069d422
|
@thimmy687 can you open a new issue with the stack trace of the failure? We may be able to preserve the old behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove redundant property setters. Read only properties have the stronger guarantee that their value will not change over time, making reasoning about the containing type's behaviour easier.
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.