Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid XML in DotSettings file #8937

Merged
1 commit merged into from Mar 6, 2021

Conversation

drewnoakes
Copy link
Member

Proposed changes

  • Fix invalid XML in DotSettings file. A consequence of this fix is that the spell checker no longer flags terms we previously added here as incorrect.

Test methodology

  • None.

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned drewnoakes Mar 6, 2021
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #8937 (d97e464) into master (e6e6e28) will decrease coverage by 13.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #8937       +/-   ##
===========================================
- Coverage   56.07%   42.93%   -13.15%     
===========================================
  Files         925      906       -19     
  Lines       65872    63403     -2469     
  Branches    12084    11545      -539     
===========================================
- Hits        36940    27220     -9720     
- Misses      25919    34456     +8537     
+ Partials     3013     1727     -1286     
Flag Coverage Δ
production 28.23% <ø> (-15.09%) ⬇️
tests 95.27% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ghost
Copy link

ghost commented Mar 6, 2021

Hello @drewnoakes!

Because this pull request has the status: auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 43 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b9cd2b5 into gitextensions:master Mar 6, 2021
@ghost ghost added this to the 3.6 milestone Mar 6, 2021
@drewnoakes drewnoakes deleted the fix-dotsettings-file branch March 6, 2021 21:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants