Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pattern matching #8972

Merged
merged 1 commit into from Mar 12, 2021
Merged

Use pattern matching #8972

merged 1 commit into from Mar 12, 2021

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Mar 11, 2021 •
edited

Proposed changes

  • Another usage of pattern matching.

Test methodology

  • Manual testing.

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned drewnoakes Mar 11, 2021
RussKie
RussKie reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily find it clearer, but I won't block this

gerhardol
gerhardol approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I prefer this way

@RussKie RussKie merged commit 749bdc2 into gitextensions:master Mar 12, 2021
@ghost ghost added this to the 3.6 milestone Mar 12, 2021
@drewnoakes drewnoakes deleted the pattern-matching branch March 12, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie left review comments

@gerhardol gerhardol gerhardol approved these changes

Assignees

@drewnoakes drewnoakes

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewnoakes @RussKie @gerhardol