Submodule: Recreate tree only at structure changes 3.5 #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This applies both for the sidepanel and browse toolbar menu. The submodule provider stsus updates always contains the full trees, but as the provider notifies when a new list is being created, sidepanel/toolbar-menu can know when a new structure must be created. * Browse submodule menu: Refactor Remove obsolete submodule detail handling SubmoduleStatusProvider calculates the required info. (cherry picked from commit ca7e05c)
RussKie
force-pushed
the
feature/submodule-sidepanel-reload-3.5
branch
from
04492f9
to
a4f2843
Compare
Codecov Report
@@ Coverage Diff @@
## release/3.5 #8978 +/- ##
===============================================
+ Coverage 56.01% 56.03% +0.02%
===============================================
Files 925 925
Lines 65621 65672 +51
Branches 12036 12046 +10
===============================================
+ Hits 36757 36799 +42
- Misses 25861 25865 +4
- Partials 3003 3008 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8902 for 3.5
Some null annotations dropped, no functional change