New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject current branch slug into the documentation link #8991
Inject current branch slug into the documentation link #8991
Conversation
335c2c7
to
658edf6
Compare
658edf6
to
53c385a
Compare
Codecov Report
@@ Coverage Diff @@
## release/3.5 #8991 +/- ##
================================================
- Coverage 56.17% 42.77% -13.41%
================================================
Files 926 906 -20
Lines 65729 63295 -2434
Branches 12035 11535 -500
================================================
- Hits 36921 27072 -9849
- Misses 25796 34493 +8697
+ Partials 3012 1730 -1282
Flags with carried forward coverage won't be shown. Click here to find out more. |
2e854ec
to
03d75aa
Compare
Better, but prefix need to be either /en/master or /en/release-xxx so logic (and XML doc) need to be adjusted. |
Why? You said you fixed the redirection, so https://git-extensions-documentation.readthedocs.io/settings.html#git-extensions-appearance-author-images-avatar-provider now correctly resolves to https://git-extensions-documentation.readthedocs.io/en/release-3.4/settings.html#git-extensions-appearance-author-images-avatar-provider. Meanwhile this change makes a release build point to the respective doc's branch. Am I overlooking something? |
With the issues I saw with the redirection, I believe it is better to not rely on it. If / points to the development version, that is what users will see by default too (currently 3.5 but it should be 3.6 or so). |
Ok, added "en/latest" for all non "release/x.y" branches |
df8ecbe
to
8b1d2ab
Compare
sure
|
24f44ac
to
cd7a3a8
Compare
cd7a3a8
to
37b86c6
Compare
I reordered Settings-Scripts so I could push main branch and build on read-the-docs so links in the app works. |
Resolves #8955