Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject current branch slug into the documentation link #8991

Merged
merged 1 commit into from Mar 18, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Mar 14, 2021

Resolves #8955

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #8991 (9c13ccc) into release/3.5 (ffa67dd) will decrease coverage by 13.40%.
The diff coverage is 10.56%.

❗ Current head 9c13ccc differs from pull request most recent head 37b86c6. Consider uploading reports for the commit 37b86c6 to get more accurate results

@@               Coverage Diff                @@
##           release/3.5    #8991       +/-   ##
================================================
- Coverage        56.17%   42.77%   -13.41%     
================================================
  Files              926      906       -20     
  Lines            65729    63295     -2434     
  Branches         12035    11535      -500     
================================================
- Hits             36921    27072     -9849     
- Misses           25796    34493     +8697     
+ Partials          3012     1730     -1282     
Flag Coverage Δ
production 28.12% <8.13%> (-15.28%) ⬇️
tests 94.76% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@RussKie RussKie force-pushed the fix_8995_manual_links branch 2 times, most recently from 2e854ec to 03d75aa Compare March 14, 2021 06:14
@gerhardol
Copy link
Member

Better, but prefix need to be either /en/master or /en/release-xxx so logic (and XML doc) need to be adjusted.

@RussKie
Copy link
Member Author

RussKie commented Mar 14, 2021

Better, but prefix need to be either /en/master or /en/release-xxx so logic (and XML doc) need to be adjusted.

Why?

You said you fixed the redirection, so https://git-extensions-documentation.readthedocs.io/settings.html#git-extensions-appearance-author-images-avatar-provider now correctly resolves to https://git-extensions-documentation.readthedocs.io/en/release-3.4/settings.html#git-extensions-appearance-author-images-avatar-provider.
So the master branch points to the latest.

Meanwhile this change makes a release build point to the respective doc's branch.

Am I overlooking something?

@gerhardol
Copy link
Member

Am I overlooking something?

With the issues I saw with the redirection, I believe it is better to not rely on it.

If / points to the development version, that is what users will see by default too (currently 3.5 but it should be 3.6 or so).

@RussKie RussKie linked an issue Mar 15, 2021 that may be closed by this pull request
@RussKie
Copy link
Member Author

RussKie commented Mar 15, 2021

Ok, added "en/latest" for all non "release/x.y" branches

@RussKie RussKie force-pushed the fix_8995_manual_links branch 2 times, most recently from df8ecbe to 8b1d2ab Compare March 15, 2021 07:02
@RussKie
Copy link
Member Author

RussKie commented Mar 15, 2021 via email

@RussKie RussKie force-pushed the fix_8995_manual_links branch 2 times, most recently from 24f44ac to cd7a3a8 Compare March 18, 2021 10:55
@RussKie RussKie merged commit 2819d5c into gitextensions:release/3.5 Mar 18, 2021
@RussKie RussKie deleted the fix_8995_manual_links branch March 18, 2021 12:20
RussKie added a commit that referenced this pull request Mar 18, 2021
@gerhardol
Copy link
Member

I reordered Settings-Scripts so I could push main branch and build on read-the-docs so links in the app works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation links are broken
2 participants