Small bits #8996
Small bits #8996
Conversation
| @@ -73,7 +73,7 @@ public void Save(RepoDistSettings settings, IReadOnlyList<ExternalLinkDefinition | |||
| } | |||
| } | |||
|
|
|||
| // TODO: refactor and outsource to the centralised SettingsSerialiser implementations. | |||
| // TODO: refactor and outsource to the centralised SettingsSerializer implementations. | |||
There was a problem hiding this comment.
I seem to remember checking that the new string matched an existing type name, but now I cannot find it. If this is supposed to be a type name, it should use cref.
There was a problem hiding this comment.
Depends on when the comment was made :) If the type doesn't currently exist - then perhaps should say "..centralised settings serializer implementations."
| @@ -153,7 +153,7 @@ public new Font Font | |||
| public Action? OpenWithDifftool { get; private set; } | |||
|
|
|||
| /// <summary> | |||
| /// Move the file viewer cursor position to the next TextMarker found in the document that matches the AppColor.HighlightAllOccurences/>. | |||
| /// Move the file viewer cursor position to the next TextMarker found in the document that matches the AppColor.HighlightAllOccurences. | |||
There was a problem hiding this comment.
I guess this meant something like
| /// Move the file viewer cursor position to the next TextMarker found in the document that matches the AppColor.HighlightAllOccurences. | |
| /// Move the file viewer cursor position to the next TextMarker found in the document that matches the <see cref="AppColor.HighlightAllOccurences"/>. |
RussKie
added
the
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
|
Please rebase and squash merge |
RussKie
added
the
📭 needs: author feedback
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 30 days. It will be closed if no further activity occurs. |
|
@drewnoakes Do you want someone else to rebase and squash this? |
@gerhardol thanks for following up. I'm swamped with work right now so won't get to look at this any time soon. If someone wants to pick it up and merge it, they're most welcome to. I would also understand if this is closed. |
ghost
removed
the
📭 needs: author feedback
|
Rebased with conflict resolve - plan to squash to one commit and merge tomorrow |
* Annotations * Remove redundant string interpolation * Fix various spelling mistakes * Add words to the project's dictionary
|
@msftbot merge in 24 hours |
|
Hello @gerhardol! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Proposed changes
Test methodology
✒️ I contribute this code under The Developer Certificate of Origin.