FileSettingsCache: No exception if Git config is inaccessible #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Mar 17, 2021
|
@RussKie will you cherry-pick to 3.5 or should I make a PR? |
|
Either way will work.
There's a 3rd option too - you can cherrypick it and push ;)
|
gerhardol
added a commit
that referenced
this pull request
Mar 17, 2021
Co-authored-by: Gerhard Olsson <gerhardol@users.noreply.github.com> (cherry picked from commit 1d7fb78)
|
done |
|
Champion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8890
Proposed changes
If the .gitconfig file is not accessible at startup you should get a prompt asking to change.
This was not happening in #8890 though, the GE config had to be edited manually.
This PR eliminates some additional exceptions at many operations due to that the FileSettingsCache cannot enable the FileSystemWatcher.
Most normal operation after this.
Note that it is still not possible to store settings, even if .gitconfig is not changed at all.
Screenshots
Before
After
Normal operation - mostly
Test methodology
Manual
Repro (part of the original issue) in the issue
✒️ I contribute this code under The Developer Certificate of Origin.