Push from empty FormCommit #9008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
approved these changes
Mar 17, 2021
GitUI/CommandsDialogs/FormCommit.cs
Outdated
| @@ -2698,6 +2701,12 @@ private void editFileToolStripMenuItem_Click(object sender, EventArgs e) | |||
|
|
|||
| private void CommitAndPush_Click(object sender, EventArgs e) | |||
| { | |||
| if (CommitAndPush.Text == _push.Text) | |||
There was a problem hiding this comment.
Slightly suspicious to compare texts, but it is the easiest way to achieve this...
There was a problem hiding this comment.
That's what I thought, too.
RussKie
reviewed
Mar 18, 2021
RussKie
added
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
mstv
force-pushed
the
feature/7179_commit_push
branch
from
0a7c057
to
b7931b6
Compare
|
I have reused the translation from FormPush and rebased. |
gerhardol
approved these changes
Mar 18, 2021
RussKie
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7179
Proposed changes
Commit & pushbutton of FormCommit into&Pushif there are no changes at all&Pushfrom FormPush toTranslatedStringsnewinTranslatedStringsScreenshots
Before
After
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.