Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Before script failure to abort action #9011

Merged
merged 1 commit into from Mar 28, 2021

Conversation

JuPrgn
Copy link
Contributor

@JuPrgn JuPrgn commented Mar 18, 2021

Follow #9001 to apply script failure detection to others Before events as suggested : #9001 (comment)


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned JuPrgn Mar 18, 2021
@pmiossec
Copy link
Member

@JuPrgn just FYI (and for subsequent PRs 😁), that's a good practice to do the PR from another branch than 'master'.

@JuPrgn
Copy link
Contributor Author

JuPrgn commented Mar 18, 2021

Ok I will create new branch next time with feature name

@JuPrgn
Copy link
Contributor Author

JuPrgn commented Mar 18, 2021

@pmiossec to squash my commits here I use "Force push with lease" on this branch is there another clean way to do this ?

@pmiossec
Copy link
Member

@pmiossec to squash my commits here I use "Force push with lease" on this branch is there another clean way to do this ?

No, that's the normal way to do it.

@JuPrgn
Copy link
Contributor Author

JuPrgn commented Mar 18, 2021

I successfully tested BeforePush, BeforePull, BeforeCheckout, BeforeMerge and BeforeFetch using a script with :

  • exit 1 action is aborted
  • exit 0 action is done

It would be great to add a setting on script settings to let user select if he want do enable/disable abort on script failure. I don't know enough C# to add it myself but this could be a usefull feature.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the changes, seem to be what is expected

@RussKie RussKie merged commit 0709c44 into gitextensions:master Mar 28, 2021
@ghost ghost added this to the 3.6 milestone Mar 28, 2021
@RussKie
Copy link
Member

RussKie commented Mar 28, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants