#9013 Use Close in Clean working directory

[bansan85]

Fixes #9013

Proposed changes

• Replace Cancel by Close to avoid confusion.

Screenshots

Before

After

Test methodology

Not needed

Test environment(s)

• Git Extensions 33.33.33
• Build dd34ed0 (Dirty)
• Git 2.30.0.windows.1
• Microsoft Windows NT 10.0.19042.0
• .NET Framework 4.8.4341.0
• DPI 96dpi (no scaling)

---

✒️ I contribute this code under The Developer Certificate of Origin.

[gerhardol]

Looks good, just there are unneeded translation items...

[gerhardol]

There is some way to avoid that this text (as well as the other using the new translated text), I do not recall how...

[bansan85]

Maybe remove the xx.Text="..." in FormCleanupRepository.Designer.cs and move it in the constructor of the form?

[gerhardol]

Should be OK, I believe there is some other trick too.
(This could maybe be fixed in a follow up, there are likely other similar strings.)

[pmiossec]

Not in front of my computer, so you have to have a look at another form but to prevent the string to be translated, you should rename the button with the prefix looking link __no_translate

[mstv]

The prefix is _NO_TRANSLATE_.

[vbjay]

Look at control names with no translate in name.

[bansan85]

Thanks, I changed names.

[RussKie]

There's no need for the Close or Cancel button.

[bansan85]

@RussKie Are you sure ? According to #9013 (comment) the question looks not answered. Would you like I remove the button only in "Clean working directory" ? Or also in "Reset changes" and "Recover lost objects" ?

[RussKie]

I don't believe this dialog requires a Close button.

[gerhardol]

For a dialog like this I believe that there should be a close button, nicr for the user than using the upper right close.

[RussKie]

Other dialogs don't have "Close" button, and I can't see why this dialog needs it either.
"Cancel" button could be useful only if the clean operation could take significant time and can be cancelled. Even in this situation "Cancel" button must either be hidden or disabled until the operation is in flight.

[RussKie]

Thank you

[bansan85]

Thanks, I didn't know what to do with this PR since some people wanted to remove this button and some other don't wanted.

[RussKie]

I still want it removed ;)