Handle errors accessing the amend state file #9037
Conversation
mstv
force-pushed
the
fix/9036_delete_amend
branch
from
04e20d1
to
28d6627
Compare
| } | ||
| catch (Exception ex) | ||
| { | ||
| MessageBox.Show(null, string.Format(CannotAccessFile, ex.Message, filePath), errorTitle, |
There was a problem hiding this comment.
Let it bubble up to the global handler?
There was a problem hiding this comment.
No, I agree to what you wrote "in this specific scenario we need to ignore the exception".
Just let the user know that something went wrong but I see no need to cancel the other operations in FormCommit.
There was a problem hiding this comment.
(If these file accesses would fail often, a retry should be offered here.)
There was a problem hiding this comment.
I think we should leave a comment here explaining why we're swallowing the exception and not sending to the global handler.
mstv
force-pushed
the
fix/9036_delete_amend
branch
from
a31fc41
to
b91e404
Compare
|
@msftbot merge in 1 day |
ghost
added
the
|
Hello @mstv! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
mstv
force-pushed
the
fix/9036_delete_amend
branch
from
b91e404
to
fcf7c93
Compare
the same way as for the commit message
mstv
force-pushed
the
fix/9036_delete_amend
branch
from
fcf7c93
to
4de9d99
Compare
ghost
merged commit 
Fixes #9036
Proposed changes
Screenshots
N/A
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.