Remove false comment regarding ColorSettingsPage #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests
ghost
assigned 
@NikolayXHD Really sorry for the mistake... |
No problem, I myself lost code in .designer.cs multiple times. Me putting events in .designer.cs file was poor design encouraged by WinForms editor. |
mstv
reviewed
Apr 14, 2021
Comment on lines
25
to
28
| public bool SettingsAreModified => | ||
| _page.SelectedThemeId != ThemeModule.Settings.Theme.Id || | ||
| _page.UseSystemVisualStyle != ThemeModule.Settings.UseSystemVisualStyle || | ||
| !_page.SelectedThemeVariations.SequenceEqual(AppSettings.ThemeVariations); |
There was a problem hiding this comment.
Support left-reading, please:
Suggested change
| public bool SettingsAreModified => | |
| _page.SelectedThemeId != ThemeModule.Settings.Theme.Id || | |
| _page.UseSystemVisualStyle != ThemeModule.Settings.UseSystemVisualStyle || | |
| !_page.SelectedThemeVariations.SequenceEqual(AppSettings.ThemeVariations); | |
| public bool SettingsAreModified => | |
| _page.SelectedThemeId != ThemeModule.Settings.Theme.Id | |
| || _page.UseSystemVisualStyle != ThemeModule.Settings.UseSystemVisualStyle | |
| || !_page.SelectedThemeVariations.SequenceEqual(AppSettings.ThemeVariations); |
GitUI/Theming/ThemeModule.cs
Outdated
| @@ -11,6 +11,8 @@ namespace GitUI.Theming | |||
| { | |||
| public static class ThemeModule | |||
| { | |||
| private static bool _suppressWin32Hooks; | |||
There was a problem hiding this comment.
I'd add documention like /// To be activated by the TestAccessor only.
There was a problem hiding this comment.
renamed variable to indicate test-only scope
gerhardol
reviewed
Apr 14, 2021
mstv
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago the event handlers from ColorsSettingsPage.cs were lost by mistake.
Before knowing that, I misinterpreted what was going on, which lead me to writing this
Here I revert that unnecessary complication, as well as the factually incorrect comment I wrote to explain it.
Test
Tested manually and with unit tests
✒️ I contribute this code under The Developer Certificate of Origin.