Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more exceptions as failed external operation #9094

Merged
merged 1 commit into from Apr 21, 2021
Merged

Handle more exceptions as failed external operation #9094

merged 1 commit into from Apr 21, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 20, 2021

Fixes #9080
amongst others

Proposed changes

  • Handle exceptions which usually are thrown by FileSystem functions, as "failed external operation",
    i.e. prefer Ignore over Report bug! in the TaskDialog showing the error

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 2e79687
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4341.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Apr 20, 2021
@RussKie RussKie merged commit 02802f9 into gitextensions:release/3.5 Apr 21, 2021
@RussKie RussKie added this to the 3.5 milestone Apr 21, 2021
@RussKie RussKie linked an issue Apr 21, 2021 that may be closed by this pull request
[NBug] Could not find a part of the path '{ProjectDir}.git\rebase-merge\git-rebase-todo' #9080
Closed
@mstv mstv deleted the fix/9080_ext_exceptions branch April 21, 2021 19:56
@mstv mstv mentioned this pull request May 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@gerhardol gerhardol gerhardol approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.

[NBug] Could not find a part of the path '{ProjectDir}.git\rebase-merge\git-rebase-todo'
3 participants
@mstv @RussKie @gerhardol