Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let installer not activate disabled telemetry #9114

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 25, 2021

Fixes #8228

Proposed changes

Workaround:

  • Let the installer not activate disabled telemetry

Unchanged:

  • Store setting from installer if setting has not existed or if turned off

Limitation:

  • The script set-telemetry.ps1 seems to be not executed at all if just changing the installation by running the installer again:

    grafik

Screenshots

Checked combobox is ignored if GitExtensions.settings already contains the TelemetryEnabled entry

grafik

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build a84a1b5
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.16299.0
  • .NET Framework 4.7.2633.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Apr 25, 2021
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Have not run

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't run but

@RussKie RussKie added this to the 3.5 milestone Apr 26, 2021
@RussKie RussKie merged commit 8aaa460 into gitextensions:release/3.5 Apr 26, 2021
@RussKie
Copy link
Member

RussKie commented Apr 26, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants