Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote path for opening with Explorer.exe #9130

Merged
1 commit merged into from Apr 29, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 27, 2021

Fixes #8512
using @RussKie's variant plus adaptation of further function

Proposed changes

Quote path given to Explorer.exe in

  • OsShellUtil.SelectPathInFileExplorer
  • OsShellUtil.OpenWithFileExplorer

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build 69cdae7
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4341.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv added this to the 3.6 milestone Apr 27, 2021
@mstv mstv self-assigned this Apr 27, 2021
@mstv
Copy link
Member Author

mstv commented Apr 28, 2021

@msftbot merge in 12 hours

@ghost ghost added the status: auto merge label Apr 28, 2021
@ghost
Copy link

ghost commented Apr 28, 2021

Hello @mstv!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 29 Apr 2021 07:59:41 GMT, which is in 12 hours

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit bf1a976 into gitextensions:master Apr 29, 2021
@mstv mstv deleted the fix/8512_select_in_explorer branch April 30, 2021 17:13
@mstv mstv modified the milestones: 3.6, 3.5.1 Apr 30, 2021
@mstv
Copy link
Member Author

mstv commented Apr 30, 2021

I have cherry-picked this to release/3.5 and added to milestone 3.5.1.

@RussKie
Copy link
Member

RussKie commented Apr 30, 2021 via email

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants