feat: add dot command to GitUICommands #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhardol
reviewed
May 2, 2021
gerhardol
reviewed
May 2, 2021
MrJithil
force-pushed
the
feature/dotCommand
branch
2 times, most recently
from
3f86717
to
3a537fd
Compare
|
@gerhardol I have added the suggested changes. Please review. |
mstv
reviewed
May 3, 2021
RussKie
added
📭 needs: author feedback
ghost
removed
the
📭 needs: author feedback
MrJithil
force-pushed
the
feature/dotCommand
branch
2 times, most recently
from
738dc57
to
ff63360
Compare
gerhardol
approved these changes
May 4, 2021
mstv
reviewed
May 4, 2021
IntegrationTests/UI.IntegrationTests/GitUICommands/RunCommandTests.cs
Outdated
Show resolved
Hide resolved
MrJithil
force-pushed
the
feature/dotCommand
branch
from
ff63360
to
8e935a4
Compare
MrJithil
force-pushed
the
feature/dotCommand
branch
from
8e935a4
to
f3e8ca3
Compare
|
@mstv @gerhardol @RussKie I have implemented the suggestion to take care Please see the evidence here. Kindly review, approve and merge if you are okay to proceed. Please feel free to revert back in case of any additional suggestions. New Evidence: Video.mp4 |
MrJithil
force-pushed
the
feature/dotCommand
branch
from
1f5a8d1
to
e4ffc7e
Compare
mstv
reviewed
May 6, 2021
MrJithil
force-pushed
the
feature/dotCommand
branch
2 times, most recently
from
49a2fa0
to
04c2901
Compare
gerhardol
reviewed
May 7, 2021
RussKie
reviewed
May 8, 2021
MrJithil
force-pushed
the
feature/dotCommand
branch
from
04c2901
to
0bf11a1
Compare
|
Please squash and it is ready to go. |
RussKie
added
📭 needs: author feedback
feat: handle path as param resolved review comment re factored the code to use `LaunchBrowse` in detached mode. removed integration tests since we decided to proceed with detached form added file supports too for path param replaced args[1] with command
MrJithil
force-pushed
the
feature/dotCommand
branch
from
0bf11a1
to
528f3b8
Compare
ghost
removed
the
📭 needs: author feedback
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
privatefunction to handle the.command in this pull request. For Eg: If a user wants to open their current repository in GitExtensions, he should trigger the commandGitExtensions .Screenshots
Before
A user needs to enter different commands to open his current repository.
GitExtensions browse .is an example.After
By these changes, a user can open the repository in GitExtensions by just triggering the command
GitExtensions .TODO
Need documentation for this command once this PR got sufficient approvals.
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.