Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BugReporter.exe to installer #9167

Merged
merged 1 commit into from May 6, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented May 6, 2021

Related to #9166

Proposed changes

  • Add BugReporter.exe to installer

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build fec6935
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 6.2.9200.0
  • .NET Framework 4.7.2633.0
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will be cherrypicked to master?

This explains why there are so few NBug for 3.5...

@mstv
Copy link
Member Author

mstv commented May 6, 2021

So this will be cherrypicked to master?

IIUC, the installer will be replaced for .NET 5.0.
BTW: Is there a shorter abbreviation which is easier to type?

This explains why there are so few NBug for 3.5...

Only uncaught exceptions from background threads are affected.

@mstv mstv merged commit b596593 into gitextensions:release/3.5 May 6, 2021
@mstv mstv deleted the fix/install_bugreporter branch May 6, 2021 22:16
@RussKie
Copy link
Member

RussKie commented May 7, 2021

OMG facepalm....
Thank you!

@RussKie RussKie added this to the 3.5.1 milestone May 7, 2021
@mstv
Copy link
Member Author

mstv commented May 7, 2021

Should I add BugReporter.exe.config yet?
In my test install, it works without. And it didn't help for Juliette's crash reports.

@RussKie
Copy link
Member

RussKie commented May 8, 2021 via email

@mstv
Copy link
Member Author

mstv commented May 8, 2021

Juliette mentioned BugReporter.exe.config, and yes, it is copied to several artifacts folders.

@mstv
Copy link
Member Author

mstv commented May 16, 2021

@RussKie:

  1. There is created a BugReporter.exe.config. In my test install, it works without. Should I add it to the 3.5 installer yet?
  2. For .NET 5.0, I presume the planned installer adaption will include BugReporter.*, too. Or else should I prepare a PR for master?

@RussKie
Copy link
Member

RussKie commented May 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants