CommitInfo: Fix up threading issues
#9205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
approved these changes
May 16, 2021
ghost
added this to the
mstv
added a commit
that referenced
this pull request
May 16, 2021
`CommitInfo`: Fix up threading issues (cherry picked from commit d3c38e6)
|
Cherry-picked to |
gerhardol
reviewed
Aug 14, 2021
| if (disposing) | ||
| { | ||
| _asyncLoadCancellation.CancelCurrent(); | ||
| ThreadHelper.JoinPendingOperations(); // those run with FileAndForget |
There was a problem hiding this comment.
Can this be reworked somehow?
This awaits all FileAndForget(), not just those created by this form.
When trying to find a solution for #9440 and add cancellation token that are disposed in REvDiff, RevGrid Dispose(), they are not executed until this has finished. So the tokens are not cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9204
Proposed changes
CommitInfo.UpdateRevisionInfoThat's why it should go into 3.5.1, too.
CommitInfoAppSettings.ShowAvailableDiffTools = falseScreenshots
N/A
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.