Use static/cached GitVersion to resolve Git path #9246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report new GitVersion after changes
ghost
assigned 
drewnoakes
approved these changes
May 30, 2021
| @@ -336,6 +336,7 @@ public static string GitCommandValue | |||
| } | |||
| set | |||
| { | |||
| GitVersion.ResetVersion(); | |||
There was a problem hiding this comment.
I considered that, but wanted to keep it simple.
It is not the end of the world to run the command again....
Can change
|
@msftbot merge in 24 hours |
|
Hello @gerhardol! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
|
Missed to squash the commit, automerge should fail... |
|
This issue was raised to the bot owners.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9229
Proposed changes
Reset GitVersion cache when setting Git command path
Report new GitVersion after changes
Use static/cached GitVersion to resolve Git path
This eliminates one
git --versioncommand during startup. At home this is about 35ms, at work 230ms (probably serialized, so delaying the startup considerably).Test methodology
Tests exist
Manual
See Git Command Log for executed command, modify gitcommand path in registry to simulate issues
✒️ I contribute this code under The Developer Certificate of Origin.