Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch GDI exception #9252

Merged
merged 2 commits into from Jun 2, 2021
Merged

Catch GDI exception #9252

merged 2 commits into from Jun 2, 2021

Conversation

mstv
Copy link
Member

@mstv mstv commented Jun 1, 2021

#9245 and #9227 for dev branch

Proposed changes

  • Log exceptions to files in %TEMP% if enabled using AppSettings.WriteErrorLog
  • Catch System.Runtime.InteropServices.ExternalException in FileStatusList.UpdateColumnWidth and log it to %TEMP%

Test methodology

  • manual

Test environment(s)

  • Git Extensions 33.33.33
  • Build e8aea1d
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET 5.0.6
  • DPI 96dpi (no scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@RussKie @mstv
Log errors (gitextensions#9227)
4593fa8 
An attempt to capture an elusive error information for gitextensions#9166.
Write an error log before showing the bug reporter dialog if AppSettings.WriteErrorLog=true.

Contributes to gitextensions#9166

(cherry picked from commit c174f1c)
@RussKie @mstv
Ignore Image.FromHbitmap failure (gitextensions#9245)
e8aea1d 
(cherry picked from commit 984cca0)
@mstv mstv self-assigned this Jun 1, 2021
RussKie
RussKie approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mstv mstv merged commit f6b19c4 into gitextensions:master Jun 2, 2021
@ghost ghost added this to the 3.6 milestone Jun 2, 2021
@mstv mstv deleted the fix/9245_gdi_exception branch June 2, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@gerhardol gerhardol gerhardol approved these changes

Assignees

@mstv mstv

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mstv @RussKie @gerhardol