RevGrid multiline indicators 3.5 #9253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
changed the title
RussKie
approved these changes
Jun 5, 2021
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 18, 2021
Cherrypicked with review comments from d7be031 (gitextensions#9253)
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 18, 2021
Cherrypicked from ee3c0d3 (gitextensions#9253)
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 18, 2021
Cherrypicked with review comments from d7be031 (gitextensions#9253)
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 18, 2021
Cherrypicked from ee3c0d3 (gitextensions#9253)
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 20, 2021
Cherrypicked with review comments from d7be031 (gitextensions#9253)
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this pull request
Jun 20, 2021
Cherrypicked from ee3c0d3 (gitextensions#9253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues from #9243 for 3.5
(unknown when the regressions occurred)
Proposed changes
These issues relate to that the commit body is not stored for commits older than 6 months.
The subject and info if the commit has multiline info is always available.
If you select the commit in the grid, the full body is loaded (again).
RevGrid tooltip: Only show "click to load" for multiline
This occurred if the commit had any related refs.
Multiline indicator only shown if Body is available
Note that there is no tooltip if there are no refs or multiline. Without the multiline indicator it is hard to understand why.
Screenshots
Test methodology
manual
✒️ I contribute this code under The Developer Certificate of Origin.