Stash: Keyboard navigation

[gerhardol]

Fixes #8108

Proposed changes

• HotKeys for next/previous stash and refresh
  Ctrl-P navigates to next older stash item, similar to how navigation in RevGrid.

• Mnemonics for the form.
  As Stashes control gets a specific hotkey, it is possible to navigate in the stashes list with Alt-H arrow /PageUp/etc too
  "&Apply stash" but "S&tash all changes" as I expect Ctrl-Alt-Up to be used for stash in current worktree.

• Stash: Keep position when dropping a stash
  Simplify deleting stashes, unless deleting the first, you would have to search for the stash close to where you just deleted the stash.

• Remove button for custom message, just make it writeable for worktree.
  Add label for mnemonics

Screenshots

After

Test methodology

Manual

---

✒️ I contribute this code under The Developer Certificate of Origin.

[mstv]

LGTM
Hotkey(s) for Write custom stash message (and for Refresh) would be nice.

[gerhardol]

LGTM
Hotkey(s) for Write custom stash message (and for Refresh) would be nice.

Implemented that too (also just showing refresh when it has effect, for worktree).

For the custom text mnemonics would be more natural than a hotkey, but then the logic for the custom message would need to be changed (remove button, add label and add to command if not empty) and I am not sure exactly how to handle.

[mstv]

Implemented that too (also just showing refresh when it has effect, for worktree).

👍 Thank you!

For the custom text mnemonics would be more natural than a hotkey, but then the logic for the custom message would need to be changed (remove button, add label and add to command if not empty) and I am not sure exactly how to handle.

I agree, it is not perfect. But I think this would be too much effort for little gain.
Though the hotkey should be displayed in the tooltip of toolStripButton_customMessage.
(BTW: The message can be double-clicked in order to enable editing it.)

[gerhardol]

I agree, it is not perfect. But I think this would be too much effort for little gain.

Replaced button with label, could also simplify the logic.
To some extent, also the label could be removed, the box is focused by default.
(Some struggling with WinForms layout as usual...)

[RussKie]

[mstv]

Works for me. (The failing test is unrelated.)

[gerhardol]

rebased without further changes

[gerhardol]

@msftbot merge in 24 hours

[ghost]

Hello @gerhardol!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Mon, 28 Jun 2021 22:17:40 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".