Reduce window flicker and loss of focus #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
If using the quick commands, I do not expect the dialog to be opened unless there are conflicts. |
|
This is what causes the flicker and the loss of focus.
|
But I find the opening of the window more annoying... |
|
Loss of focus is an accessibility issue. We are showing the progress dialog
anyway, so can't see your argument here.
|
gerhardol
approved these changes
Jul 2, 2021
mstv
approved these changes
Jul 2, 2021
1. Force child window ownership to FormBrowse 2. Show the rebase dialog *before* starting any operations. This is what appears to be the main cause of the loss of focus. The dialog isn't yet shown when we invoke the progress dialog, which is then gets closed but the window that spawned it is not visible. MS Windows gets confused and pushes another window to the foreground, thus causing the app to lose focus.
|
I rolled all "Owner" related changes as in some scenarios those could lead to the active top window could get under another window with the same parent. Since now the rebase dialog is visible and lives longer any of its children, the existing ownership model is correct. |
mstv
pushed a commit
to mstv/gitextensions
that referenced
this pull request
Jul 3, 2021
(cherry picked from commit 8f9d901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reduce window flicker and loss of focus
Force child window ownership to FormBrowse
Show the rebase dialog before starting any operations. This is what appears to be the main cause of the loss of focus. The dialog isn't yet shown when we invoke the progress dialog, which is then gets closed but the window that spawned it is not visible. MS Windows gets confused and pushes another window to the foreground, thus causing the app to lose focus.
Screenshots
Before
After
✒️ I contribute this code under The Developer Certificate of Origin.