Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PathUtil handling of spaces in file names (for 3.5) #9313

Merged
merged 1 commit into from Jun 29, 2021
Merged

Fix PathUtil handling of spaces in file names (for 3.5) #9313

merged 1 commit into from Jun 29, 2021

Conversation

mdonatas
Copy link
Contributor

Cherry picked #9305 for 3.5 version

Test methodology

  • Ran unit tests with and without fix to confirm that the same problem was in 3.5 too and that this fix fixed it for 3.5

Test environment(s)

  • Git Extensions 33.33.33
  • Build eefc1bb
  • Git 2.31.1.windows.1
  • Microsoft Windows NT 10.0.19042.0
  • .NET Framework 4.8.4390.0
  • DPI 192dpi (200% scaling)

✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned mdonatas Jun 28, 2021
@RussKie RussKie merged commit e11bf41 into gitextensions:release/3.5 Jun 29, 2021
@RussKie
Copy link
Member

RussKie commented Jun 29, 2021

Thank you

@RussKie RussKie added this to the 3.5.1 milestone Jul 4, 2021
@mdonatas mdonatas deleted the path-util-fix branch October 24, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

@mstv mstv mstv approved these changes

Assignees

@mdonatas mdonatas

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdonatas @RussKie @mstv